Ho Tony, Tomi, > Am 08.01.2019 um 16:56 schrieb Tony Lindgren <tony@xxxxxxxxxxx>: > > * Tomi Valkeinen <tomi.valkeinen@xxxxxx> [190108 07:57]: >> On 07/01/19 21:34, H. Nikolaus Schaller wrote: >> >>>>> If there's only one port, then it is redundant and you should drop reg >>>>> instead. >>> >>> If I remember correctly it was required by older omapdrm code (which >>> did scan for a reg property) but that may have changed. Therefore I've >>> added Tomi to this discussion. >> >> I don't think so. The code looks for 'reg', but if it's not there, then >> it's considered 0. > > FYI, the binding doc for the graph bindings is at > Documentation/devicetree/bindings/graph.txt if there is > any questions on how things should work. I interpret it that "port@number" is only needed if there are multiple ports and there should not be any "@" or "reg" for the single port case. Although it seems not to be explicitly forbidden. The &dss port doesn't have it either. So let's remove the reg = <0>; It also seems that #address-cells = <1>; #size-cells = <0>; is not required in this case and can also be removed. I've tested and it works with v5.0-rc1. There is an edited patch [1] but IMHO you as the original author should post it. BR, Nikolaus [1]: http://git.goldelico.com/?p=letux-kernel.git;a=commit;h=e46369390f62ce7176e91dfa443185e4b097ef4b
