On Mon, 17 Dec 2018, Julia Lawall wrote: > Should be clear what the problem is :) (lines 844 and 845). Is this to be submitted upstream (via the MFD tree) at any point? > ---------- Forwarded message ---------- > Date: Mon, 17 Dec 2018 15:35:17 +0800 > From: kbuild test robot <lkp@xxxxxxxxx> > To: kbuild@xxxxxx > Cc: Julia Lawall <julia.lawall@xxxxxxx> > Subject: [omap:droid4-pending-mdm-v4.20 15/21] > drivers/mfd/motorola-mdm.c:845:1-6: ERROR: reference preceded by free on > line 844 > > CC: kbuild-all@xxxxxx > CC: linux-omap@xxxxxxxxxxxxxxx > TO: Tony Lindgren <tony@xxxxxxxxxxx> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git droid4-pending-mdm-v4.20 > head: ab13333f2ab58d5710f1a05d82630440265b6129 > commit: 0c1bc81ba976bcd480d6e3c3009a28589f8427c0 [15/21] mfd: motmdm: Add Motorola TS 27.010 serdev driver for devices like droid4 > :::::: branch date: 7 hours ago > :::::: commit date: 7 hours ago > > >> drivers/mfd/motorola-mdm.c:845:1-6: ERROR: reference preceded by free on line 844 > > # https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/commit/?id=0c1bc81ba976bcd480d6e3c3009a28589f8427c0 > git remote add omap https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git > git remote update omap > git checkout 0c1bc81ba976bcd480d6e3c3009a28589f8427c0 > vim +845 drivers/mfd/motorola-mdm.c > > 0c1bc81b Tony Lindgren 2018-12-16 824 > 0c1bc81b Tony Lindgren 2018-12-16 825 static void motmdm_cdev_free_one(struct motmdm_cdev *cdata) > 0c1bc81b Tony Lindgren 2018-12-16 826 { > 0c1bc81b Tony Lindgren 2018-12-16 827 struct motmdm_dlci *mot_dlci = cdata->dlci; > 0c1bc81b Tony Lindgren 2018-12-16 828 struct motmdm *ddata = mot_dlci->privdata; > 0c1bc81b Tony Lindgren 2018-12-16 829 > 0c1bc81b Tony Lindgren 2018-12-16 830 down_write(&cdata->rwsem); > 0c1bc81b Tony Lindgren 2018-12-16 831 cdata->disconnected = true; > 0c1bc81b Tony Lindgren 2018-12-16 832 if (cdata->count) > 0c1bc81b Tony Lindgren 2018-12-16 833 wake_up_interruptible(&mot_dlci->read_queue); > 0c1bc81b Tony Lindgren 2018-12-16 834 up_write(&cdata->rwsem); > 0c1bc81b Tony Lindgren 2018-12-16 835 > 0c1bc81b Tony Lindgren 2018-12-16 836 cdev_del(&cdata->cdev); > 0c1bc81b Tony Lindgren 2018-12-16 837 device_destroy(ddata->class, > 0c1bc81b Tony Lindgren 2018-12-16 838 MKDEV(MAJOR(ddata->dev_id), mot_dlci->line)); > 0c1bc81b Tony Lindgren 2018-12-16 839 kfree(cdata->write_buf); > 0c1bc81b Tony Lindgren 2018-12-16 840 > 0c1bc81b Tony Lindgren 2018-12-16 841 motmdm_unregister_dlci(ddata->dev, cdata->dlci); > 0c1bc81b Tony Lindgren 2018-12-16 842 kfifo_free(&mot_dlci->read_fifo); > 0c1bc81b Tony Lindgren 2018-12-16 843 kfree(cdata->dlci); > 0c1bc81b Tony Lindgren 2018-12-16 @844 kfree(cdata); > 0c1bc81b Tony Lindgren 2018-12-16 @845 cdata->dlci = NULL; > 0c1bc81b Tony Lindgren 2018-12-16 846 } > 0c1bc81b Tony Lindgren 2018-12-16 847 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
