On 14-12-18, 13:12, Russell King - ARM Linux wrote: > On Fri, Dec 14, 2018 at 10:09:23AM +0530, Viresh Kumar wrote: > > On 13-12-18, 18:01, Russell King wrote: > > > diff --git a/arch/arm/mach-spear/generic.h b/arch/arm/mach-spear/generic.h > > > index 909b97c0b237..815333fc320c 100644 > > > --- a/arch/arm/mach-spear/generic.h > > > +++ b/arch/arm/mach-spear/generic.h > > > @@ -20,6 +20,8 @@ > > > > > > #include <asm/mach/time.h> > > > > > > +extern volatile int prima2_pen_release; > > > > prima2 ? > > > > I haven't tried but this may cause build regressions as well, I am > > surprised on how this passed for you. > > Thanks. > > These patches aren't all build tested - Ah okay. > I don't see the point of wasting > hours build testing when these platforms /really/ need something better. I was expecting it to be build tested at least, to be honest. But anyway, we will see build failures from bots if any such cases exist. > This is not supposed to be a finished patch, but a patch to get folk > to do something about this issue. > > Please fix this issue properly. I can't give you a patch to do that, > you need to sort it yourself, but failure to do anything _will_ result > in an updated version of this patch being merged. Yeah, I know. I have seen the thread and it was lack of knowledge in the beginning which made us copy code from rest of ARM platforms. That was stupid and there can't be any excuse for that. Unfortunately, I don't have access to hardware to test this stuff and so wouldn't be possible to send a patch as well. Lets get your patch merged at least. -- viresh
