On Sun 2018-12-02 17:29:32, Tony Lindgren wrote: > I noticed that the Android v3.0.8 kernel on droid4 is using different > keypad values from the mainline kernel and does not have issues with > keys occasionally being stuck until pressed again. Turns out there was > an earlier patch posted to fix this as "Input: omap-keypad: errata i689: > Correct debounce time", but it was never reposted to fix use macros > for timing calculations. > > This updated version is using macros, and also fixes the use of the > input clock rate to use 32768KiHz instead of 32000KiHz. And we want to > use the known good Android kernel values of 3 and 6 instead of 2 and 6 > in the earlier patch. > > Cc: Axel Haslam <axelhaslam@xxxxxx> > Cc: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> > Cc: Illia Smyrnov <illia.smyrnov@xxxxxx> > Cc: Marcel Partap <mpartap@xxxxxxx> > Cc: Merlijn Wajer <merlijn@xxxxxxxxxx> > Cc: Michael Scott <hashcode0f@xxxxxxxxx> > Cc: NeKit <nekit1000@xxxxxxxxx> > Cc: Pavel Machek <pavel@xxxxxx> > Cc: Sebastian Reichel <sre@xxxxxxxxxx> > Reported-by: Pavel Machek <pavel@xxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> So, if I press key "." quickly on console in 4.18.0-rc4-88970-gf075a2c-dirty it starts repeating. I could reproduce it 3 times from tree tries. Then I decided to test your patch, and so I booted 4.20-rc5+ using kexec. Turns out, I can't reproduce that repeat there... I tried more than 10 times. But that's before your patch. So -- bad news for you -- seems like someone -- maybe you -- already fixed this. (But that does not mean the patch is bad idea). Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
