On 06/11/18 17:28, Tony Lindgren wrote: > We're missing a call to of_platform_depopulate() on errors for dsi. > Looks like dss is already doing this. > > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> > --- > drivers/gpu/drm/omapdrm/dss/dsi.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c > --- a/drivers/gpu/drm/omapdrm/dss/dsi.c > +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c > @@ -5429,15 +5429,19 @@ static int dsi_probe(struct platform_device *pdev) > } > > r = of_platform_populate(dev->of_node, NULL, NULL, dev); > - if (r) > + if (r) { > DSSERR("Failed to populate DSI child devices: %d\n", r); > + goto err_uninit_output; > + } > > r = component_add(&pdev->dev, &dsi_component_ops); > if (r) > - goto err_uninit_output; > + goto err_of_depopulate; > > return 0; > > +err_of_depopulate: > + of_platform_depopulate(dev); > err_uninit_output: > dsi_uninit_output(dsi); > err_pm_disable: > Thanks, looks good to me. I'll push to drm-misc-fixes. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki