Re: [PATCH 1/2] dt-bindings: pinctrl: k3-am6: Introduce pinmux definitions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 14:20-20181109, Vignesh R wrote:
> >> +++ b/include/dt-bindings/pinctrl/k3-am6.h
> > 
> > Are we thinking of creating headers for every single SoC?
> 
> We would need one file per SoC family (i.e atleast one for K3 family as
> a whole) as pinctrl register layout is significantly different than

Yes, I am aware of the same.

> other TI SoCs. I can rename the file to include/dt-bindings/pinctrl/k3.h
> to indicate its intended to be common for all K3 SoCs, if you prefer.

Yes, that would be the preference. There are two types of IO muxing IPs
(the equivalent of padconf from omap days) that I
am aware of. However these are all within the same 32bit definitions and
I know there has been significant effort spend by designers based on
software team feedbacks to maintain consistency as much as possible
within technological constraints.

So macros could be used to differentiate within the same header. The
deltas do exist, however they can be differentiated easily.

You should have access to the alternative solution, and even if you
cannot publish it, you should plan the header to scale easily when the
time is appropriate as a trivial additional patch.

For the rest.. Will wait for v2.

-- 
Regards,
Nishanth Menon



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux