On 05/11/18 23:46, Laurent Pinchart wrote: > Hi Tony, > > On Monday, 5 November 2018 22:14:46 EET Tony Lindgren wrote: >> * Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [181105 19:23]: >>> This patch applies on top of the "[PATCH v2 0/4] omapdrm: Fix runtime PM >>> issues at module load and unload time" series. It demonstrates what I >>> think is the proper long term fix for the issue addressed by patch 4/4. >>> Due to its nature, I don't think this patch should be applied for v4.20 >>> as it qualifies for very careful testing, hence my proposal to fix the >>> runtime PM problem with 4/4 and to queue this patch for v4.21. >> >> To me this seems like a less risky fix compared to conditional >> runtime PM calls in patch 4. Conditional calls with usecounts seem >> to always break one way or another.. So would be nice to go with >> this one if possible. > > If Tomi is fine with this, and after careful testing, I have no issue with > merging this patch squashed with 4/4 for 4.20-rc. I didn't try it yet, but it makes sense and looks good to me, so I think we should try to go with this one instead of the 4/4. Btw, Peter also reported this one on linux-next on beagle-xm: http://horus.dhcp.ti.com:7777/epowaxifuk.go Venc has always been a bit odd with the clocks, and with a quick look at the code I didn't see what's wrong there, unless we have a mismatch with the runtime_get/puts. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
