Re: [PATCH 04/11] clk: ti: clkctrl: support multiple clkctrl nodes under a cm node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tero Kristo (2018-10-16 00:37:06)
> On 16/10/18 02:38, Stephen Boyd wrote:
> >                       return;
> > @@ -531,10 +530,9 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
> >                * Create default clkdm name, replace _cm from end of parent
> >                * node name with _clkdm
> >                */
> > -             strcpy(provider->clkdm_name, node->parent->name);
> > -             provider->clkdm_name[strlen(provider->clkdm_name) - 2] = 0;
> > +             provider->clkdm_name[strlen(provider->clkdm_name) - 5] = 0;
> >       } else {
> > -             provider->clkdm_name = kmalloc(strlen(node->name), GFP_KERNEL);
> > +             provider->clkdm_name = kasprintf(GFP_KERNEL, "%pOFn", node->name);
> 
> should be:
> 
>   +             provider->clkdm_name = kasprintf(GFP_KERNEL, "%pOFn", node);
> 
> ...instead right?
> 

Yes. Thanks for catching it!





[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux