On Fri 2018-09-28 13:29:46, Dan Murphy wrote: > From: Pavel Machek <pavel@xxxxxx> > > This adds backlight support for the following TI LMU > chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. > > It controls LEDs on Droid 4 > smartphone, including keyboard and screen backlights. > > Signed-off-by: Milo Kim <milo.kim@xxxxxx> > [add LED subsystem support for keyboard backlight and rework DT > binding according to Rob Herrings feedback] > Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx> > [remove backlight subsystem support for now] > Signed-off-by: Pavel Machek <pavel@xxxxxx> So... this driver adds support for LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697 (or it did when I signed it off). The rest of the series does not really bring any advantages (you claim it may add advantages in future). It takes code out of common driver and duplicates it. Could we take this patch, get the basic support for LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697, and then split out the drivers when we actually gain some advantage doing so (and also when the costs are clear)? Thanks, Pavel > drivers/leds/Kconfig | 8 ++ > drivers/leds/Makefile | 1 + > drivers/leds/ti-lmu-led-common.c | 138 +++++++++++++++++++++++++++++++ > drivers/leds/ti-lmu-led-common.h | 54 ++++++++++++ > 4 files changed, 201 insertions(+) > create mode 100644 drivers/leds/ti-lmu-led-common.c > create mode 100644 drivers/leds/ti-lmu-led-common.h -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
