[bug report] ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

Hello Janusz Krzysztofik,

The patch 0812db943748: "ARM: OMAP1: ams-delta: assign MODEM IRQ from
GPIO descriptor" from Sep 10, 2018, leads to the following static
checker warning:

	arch/arm/mach-omap1/board-ams-delta.c:891 ams_delta_modem_init()
	warn: unsigned 'ams_delta_modem_ports[0].irq' is never less than zero.

arch/arm/mach-omap1/board-ams-delta.c
   883   */
   884  static int __init ams_delta_modem_init(void)
   885  {
   886          int err;
   887  
   888          if (!machine_is_ams_delta())
   889                  return -ENODEV;
   890  
   891          if (ams_delta_modem_ports[0].irq < 0)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Impossible

   892                  return ams_delta_modem_ports[0].irq;
   893  
   894          omap_cfg_reg(M14_1510_GPIO2);
   895  
   896          /* Initialize the modem_nreset regulator consumer before use */
   897          modem_priv.regulator = ERR_PTR(-ENODEV);
   898  
   899          err = platform_device_register(&ams_delta_modem_device);
   900  
   901          return err;
   902  }
   903  arch_initcall_sync(ams_delta_modem_init);

regards,
dan carpenter