On 09/27/2018 02:38 PM, Tony Lindgren wrote:
With runtime PM autosuspend we may have i2c-omap left into enabled state if an i2c client reconfigures registers for suspend as for example pixcir_ts driver does. Let's make sure i2c-omap is suspended by adding SET_NOIRQ_SYSTEM_SLEEP_PM_OPS. Let's also get rid of some ifdefs while at it and replace them with __maybe_unused as SET_RUNTIME_PM_OPS and SET_NOIRQ_SYSTEM_SLEEP_PM_OPS already deal with the various PM Kconfig options. Cc: Dave Gerlach <d-gerlach@xxxxxx> Cc: Grygorii Strashko <grygorii.strashko@xxxxxx> Cc: Keerthy <j-keerthy@xxxxxx> Cc: Tero Kristo <t-kristo@xxxxxx> Reported-by: Keerthy <j-keerthy@xxxxxx> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> --- This problem is not yet exposed with the mainline kernel so this can wait for v4.20 merge window no problem.
Reviewed-by: Grygorii Strashko <grygorii.strashko@xxxxxx> -- regards, -grygorii