Re: [PATCH] mmc: omap_hsmmc: Kill off cover detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Linus,

I love your patch! Yet something to improve:

[auto build test ERROR on ulf.hansson-mmc/next]
[also build test ERROR on v4.19-rc5 next-20180925]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Linus-Walleij/mmc-omap_hsmmc-Kill-off-cover-detection/20180925-092420
base:   git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/mmc/host/omap_hsmmc.c: In function 'omap_hsmmc_resume':
>> drivers/mmc/host/omap_hsmmc.c:2118:2: error: implicit declaration of function 'omap_hsmmc_protect_card'; did you mean 'omap_hsmmc_init_card'? [-Werror=implicit-function-declaration]
     omap_hsmmc_protect_card(host);
     ^~~~~~~~~~~~~~~~~~~~~~~
     omap_hsmmc_init_card
   cc1: some warnings being treated as errors

vim +2118 drivers/mmc/host/omap_hsmmc.c

a45c6cb81 Madhusudhan Chikkature 2009-01-23  2101  
a45c6cb81 Madhusudhan Chikkature 2009-01-23  2102  /* Routine to resume the MMC device */
a791daa15 Kevin Hilman           2010-05-26  2103  static int omap_hsmmc_resume(struct device *dev)
a45c6cb81 Madhusudhan Chikkature 2009-01-23  2104  {
927ce944a Felipe Balbi           2012-03-14  2105  	struct omap_hsmmc_host *host = dev_get_drvdata(dev);
927ce944a Felipe Balbi           2012-03-14  2106  
927ce944a Felipe Balbi           2012-03-14  2107  	if (!host)
927ce944a Felipe Balbi           2012-03-14  2108  		return 0;
a45c6cb81 Madhusudhan Chikkature 2009-01-23  2109  
fa4aa2d48 Balaji T K             2011-07-01  2110  	pm_runtime_get_sync(host->dev);
11dd62a74 Denis Karpov           2009-09-22  2111  
cd03d9a85 Rajendra Nayak         2012-04-09  2112  	if (host->dbclk)
94c181494 Rajendra Nayak         2012-06-27  2113  		clk_prepare_enable(host->dbclk);
2bec08937 Adrian Hunter          2009-09-22  2114  
31f9d4635 Eliad Peller           2011-11-22  2115  	if (!(host->mmc->pm_flags & MMC_PM_KEEP_POWER))
70a3341a7 Denis Karpov           2009-09-22  2116  		omap_hsmmc_conf_bus_power(host);
1b331e69a Kim Kyuwon             2009-02-20  2117  
b62f62281 Adrian Hunter          2009-09-22 @2118  	omap_hsmmc_protect_card(host);
fa4aa2d48 Balaji T K             2011-07-01  2119  	pm_runtime_mark_last_busy(host->dev);
fa4aa2d48 Balaji T K             2011-07-01  2120  	pm_runtime_put_autosuspend(host->dev);
3932afd51 Ulf Hansson            2013-09-25  2121  	return 0;
a45c6cb81 Madhusudhan Chikkature 2009-01-23  2122  }
a45c6cb81 Madhusudhan Chikkature 2009-01-23  2123  #endif
a45c6cb81 Madhusudhan Chikkature 2009-01-23  2124  

:::::: The code at line 2118 was first introduced by commit
:::::: b62f622812c5aaacad217fd8f4445562b917df6d omap_hsmmc: protect the card when the cover is open

:::::: TO: Adrian Hunter <adrian.hunter@xxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux