Re: [PATCH 0/3] Fix OMAP EHCI probe & assorted cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [180911 16:12]:
> On Tuesday, 11 September 2018 18:16:41 EEST Tony Lindgren wrote:
> > * Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [180911 15:10]:
> > > Hello,
> > > 
> > > This series fixes a v4.19-rc1 regression that results in OMAP EHCI failing
> > > to probe (patch 1/3) and then moves on to cleaning up related code
> > > (patches 2/3 and 3/3).
> > > 
> > > The first patch is a regression fix and should thus be merged before
> > > v4.19. The other two patches can wait until v4.20.
> > 
> > Hmm can you please check again with this patch applied:
> > 
> > "[PATCH] mfd: omap-usb-host: Fix dts probe of children"
> 
> This fixes the issue for me.
> 
> Tested-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>

OK good to hear.

> > That was supposed to be queued for v4.18 but fell through the
> > cracks and I only recently noticed it but Lee has it tagged
> > now for v4.19-rc series.
> > 
> > But maybe there are additional issues..
> 
> I think we can go one step further and avoid using fs_initcall, but that can 
> wait for v4.20. What's your opinion on that ? If you agree I'll resubmit this 
> series rebased on top of the aforementioned patch.

Yes sounds good to me. Actually with ti-sysc we're probing the
interconnect target modules at module_init time, so any children
will only get probed after that and the fs_initcall is not
doing anything before that mhuwhaaaahaa.

But yeah hopefully the fs_initcall is no longer needed with
device tree based booting even before we have all the dts
files using ti-sysc.

> > > Tony, as patch 1/3 fixes a problem introduced by one of your DT changes,
> > > could you please review it ? Out of curiosity, is ethernet on the
> > > Pandaboard not part of your regression tests ?
> > 
> > Sorry not any longer.. I've switched over to wlan based
> > setup for PM testing:
> > 
> > 1. u-boot downloads kernel dtb and modules.tar.gz and writes
> >    modules.tar.gz to MMC card
> > 
> > 2. on kernel boot, first modules.tar.gz is unpacked
> > 
> > 3. distro brings up wlan but no USB ether
> > 
> > So I can now test also PM on pandaboard-es. I do have ohci
> > enabled on droid4 though for mdm6600 modem, but usually have
> > ehci disabled as the w3glte modem on ehci does not yet work
> > with mainline kernel.
> 
> :-/ If you have a test script that analyzes the kernel log, it would be useful 
> to add a check to verify that the USB ethernet interface chip is detected. 
> That would prevent the regression we're seeing here.

Yeah sorry about the regression.

Hrm well it goes back to the droid4 lcd patches again that I've
been carrying along :) I did not notice this was still pending
too buried into the pile I was carrying until recently.. The
original fix was already sent back in April.

I in fact worked all summer using Linux next (working) snapshots
on droid4 with a lapdock over ssh and mdm6600 modem on it's ohci
bus being my main connection. So the *hci is getting tested by
real use in this case, no need to analyze kernel logs unless
something goes wrong.

Regards,

Tony



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux