On Mon, Sep 10, 2018 at 12:55 AM Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx> wrote: > Now as Amstrad Delta board - the only user of this driver - provides > GPIO lookup tables, switch from GPIO numbers to GPIO descriptors and > use the table to locate required GPIO pins. > > Declare static variables for storing GPIO descriptors and replace > gpio_ function calls with their gpiod_ equivalents. Move GPIO lookup > to the driver probe function so device initialization can be deferred > instead of aborted if a GPIO pin is not yet available. > > Pin naming used by the driver should be followed while respective GPIO > lookup table is initialized by a board init code. > > Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx> > Signed-off-by: Janusz Krzysztofik <jmkrzyszt@xxxxxxxxx> Good work as usual: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> FWIW I think the entire drivers/video/fbdev/omap/* could be pretty easy to migrate to DRM if you compare the simple drivers/gpu/drm/pl111 or drivers/gpu/drm/tve200 drivers. Just inspiration! :) Yours, Linus Walleij
