On 08/30/2018 03:18 PM, Pavel Machek wrote: > Hi! > >>> Here's preview of driver for TI LMU. It controls LEDs on Droid 4 >>> smartphone, including keyboard and screen backlights. >>> >>> This adds backlight support for the following TI LMU >>> chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. >>> >>> Signed-off-by: Milo Kim <milo.kim@xxxxxx> >>> [add LED subsystem support for keyboard backlight and rework DT >>> binding according to Rob Herrings feedback] >>> Signed-off-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx> >>> [remove backlight subsystem support for now] >>> Signed-off-by: Pavel Machek <pavel@xxxxxx> >>> >>> --- >>> >>> Does it looks mostly reasonable? I guess it will need some >>> s/BACKLIGHT/LEDS/ , and I'll need to remove my debugging hacks. >>> >>> I'd prefer this to be LED driver, first; I'll need to figure out what >>> to do with backlight. I guess something like existing "backlight" >>> trigger should do the trick. >>> >> >> I looked at this driver from Milo before submitting a specific LM3697 driver. > > Aha. I did not realize that was for same hardware... I should have > cc-ed you, I guess. > No worries Jacek cc'd me. >> I do not like this driver. >> I don't like that it smashes numerous devices into some structure with varying register maps. >> > > Can you elaborate? The chips are similar enough that single driver > makes sense, and we certainly want to maintain one driver, not 6 > drivers differing only in .. what exactly? Well I think it is justified to have independent drivers as each device has different features from this basic LED driver. If we are just looking for basic support then yes this driver is fine. But here is where a single driver will start getting messy and support difficult LM3533 has ALS and an ADC for an ALS analog sensor LM3631 has no ALS functionality LM3632 has strobe functionality and no ramp support LM3633 has indicator support coupled with the hvled support LM3695 does not even appear to be available publicly LM3697 is the only device that that this driver could be used for as is. In addition if I wanted to only support a single device I have to pull in the full data file that defines all the other devices. That is pretty bad to increase the size of the kernel image to have support for devices that are not even on the target product. The ti-lmu data file alone is ~15k, the ti-lmu code does not even build with this patch (So this is a nack on the patch as it is.) but commenting out the offending code gives me at least ~23k more data on top of the ti-lmu MFD framework which is ~33k. That is ~71k of code just to support 1 LED device that is 3x what we have now. That is not good for IoT devices. The LM3697 is 22k without ramp support. It may make sense for Droid 4 but not for most other customer products. This is why I created the LM3697 as a customer is only using that specific part on their end product so why would they want to pull in data structures for 5 other devices? It won't make sense for IoT devices as memory real estate is critical. And I will continue. TI LMU really means nothing unless you know what LMU stands for. But this also now implies support for all of TI's lighting products which will confuse the heck out of customers and TI support staff. We have a similar issue in our SoC sound CODECs code that we are attempting to clean up. We have a generic driver that is supposed to support a common set of features but when extending support for other features the code gets very complicated and it is almost more beneficial to re-write and create a new driver. I would be OK with creating a ti-lmu framework that commonizes the functionality and create children that register to that framework but even that is over kill. > >> Not only that but it appears that you just pulled this driver from a repo and posted it without clean up. >> > > a) No I did not, feel free to generate a diff. > No I looked at this driver before and determined a re-write was a waste of time. If you look that the LM3697 driver I submitted it configures the banks via the config file. Only the ramp code is missing and the code is much simpler in nature. We could adopt that code to extend out to the other devices as well and base the register map deltas on the device configuration file. I am already using the fwnode calls and setting up the banks. > b) Even if I did, why would that be a problem? So what you are saying is all I have to do is look for other peoples work pull it in to a branch slap a new copyright on it, push to a list and claim support? I don't think you checked with the original author on pushing it upstream. Milo has not updated his email with a public one unless you sent him a private email and received and ack on pushing > >> If the devices share register maps and can be added to families I would prefer to do it that way. >> >> So if the LM3695 and LM3697 share the same features and register map they should be one driver >> The LM363x series may be able to be a different driver. > > Well all 6 chips this driver supports seem to be similar enough, so > that single driver makes sense. See above on device differentiation. So in my opinion a single driver that supports basic functionality is good but when adding additional support this driver will get very complicated as to only allow different features for different devices. Dan > > Best regards, > Pavel > -- ------------------ Dan Murphy
