+Cc: Rafael On Mon, May 21, 2018 at 6:46 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > On Fri, May 18, 2018 at 10:30:07AM -0700, Tony Lindgren wrote: >> If pm_runtime_get_sync() fails we should call pm_runtime_put_noidle(). >> This is probably not a critical fix as we should only hit this when >> things are broken elsewhere. > > This feels like a bug in the runtime PM APIs to be honest - I'd really > not expect that if a function call like a get failed there'd be any > cleanup to do. I'd expect a very high proportion of users to have the > same problem due to this. I don't remember the full and correct explanation, but there is a rationale behind such behaviour (I suppose it's related to sync/async agnosticism of RPM ops) -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
