Re: [PATCH 4/4] omap4-droid4: Use software debounce for gpio-keys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Pavel Machek <pavel@xxxxxx> [180518 07:23]:
> BTW, did you notice that debouncing is wrong on most of the keyboard?
> If you double click a key (most will do, for example "J") it will fail
> to recognize second release and instead of expected "jj", you get
> autorepeat ("jjjjjjjjjjjjjjjjjjjjjj...").

Hmm OK I have not seen that one.

> Ok, I guess main keyboard is not on GPIO...

No it's using omap4-keypad.c.

> > @@ -128,6 +128,7 @@
> >  			gpios = <&gpio5 26 GPIO_ACTIVE_LOW>; /* gpio154 */
> >  			linux,code = <KEY_VOLUMEDOWN>;
> >  			linux,can-disable;
> > +			debounce-interval = <10>;
> 
> I'd say this subtlety is worth a comment.

Good idea, I'll add a comment "Value above 7.95ms for no GPIO hardware
debounce". I'll do it also for duovero.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux