* Tero Kristo <t-kristo@xxxxxx> [180518 07:02]: > On 18/05/18 07:32, Keerthy wrote: > > > > > > On Friday 18 May 2018 03:15 AM, Tony Lindgren wrote: > > > * Keerthy <j-keerthy@xxxxxx> [180516 15:21]: > > > > + /* Only AM43XX can lose pwrdm context during rtc-ddr suspend */ > > > > + if (soc_is_am43xx()) { > > > > + nb.notifier_call = cpu_notifier; > > > > + cpu_pm_register_notifier(&nb); > > > > + } > > > > + > > > > > > Hmm in patch 3/4 you add omap4_pwrdm_save_context(), I think > > > that we'd want to run with the notifier for cpuidle on omap4? > > > > Okay i believe that is not needed for cpuidle on omap4. PRCM on wakeup > > domain so save/restore not needed for powerdomain on omap4. > > > > Tero can confirm the same. > > Yea I don't believe this is needed. Only certain portions of the OMAP4 PRCM > lose context during device off mode (which is currently not supported by > linux), and whatever portions do lose, they should use the SAR_RAM approach > for context save/restore, as that is supported by HW/ROM code. OK > > Should i rename omap4_pwrdm_save_context to am43xx_pwrdm_save_context to > > avoid confusion? No need to, it follows the naming prm44xx.c. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html