On Tuesday 08 May 2018 06:18 PM, Andrew Lunn wrote: > On Tue, May 08, 2018 at 01:56:38PM +0530, Sekhar Nori wrote: >> A well timed kernel preemption in the time_after() loop >> in wait_for_idle() can result in a spurious timeout >> error to be returned. >> >> Fix it by checking for status of hardware before returning >> timeout error. >> >> Signed-off-by: Sekhar Nori <nsekhar@xxxxxx> > > I've seen this with other drivers as well. > > I suggest you make use of readx_poll_timeout(), or one of its > cousins. They get this right. Thanks for pointing me to these. I somehow thought these helpers are only available with regmap. Sending a version using readl_poll_timeout(). I know __raw_readl() is used elsewhere in the driver, but I think that should be cleaned up sometime to use readl_relaxed() at least. So not sure if there is benefit in persisting with existing accessor. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
