On Fri, Mar 2, 2018 at 1:14 PM, Pavel Machek <pavel@xxxxxx> wrote: >> >> Ok, so this code looks pretty crazy to me: I tried removing the >> >> "of_find_spi_gpio" part, and audio started working. >> > >> > Hmm. Looks like audio is working w/o any changes, too. Not sure why >> > festival hung on me before. >> >> Does it mean that mainline is working find for you or >> do we need to look deeper into the problem in the OF >> lookup? > > It now works for me. > > (But take a look at the patch I sent -- I believe you are still > overwriting return values in a bad way, and code is quite confusing). I think that code is a result of piled fixes, so noone really designed it to look like that. I'll try to look at it, I am a bit afraid of the code since I've broken so many things with it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
