Re: [PATCH] ARM: OMAP2+: Handle errors from cpu_pm_enter()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Grygorii Strashko <grygorii.strashko@xxxxxx> [180209 20:09]:
> On 02/09/2018 11:47 AM, Tony Lindgren wrote:
> > @@ -196,18 +199,18 @@ static int omap_enter_idle_coupled(struct cpuidle_device *dev,
> >   		}
> >   	}
> > -	/*
> > -	 * Call idle CPU PM exit notifier chain to restore
> > -	 * VFP and per CPU IRQ context.
> > -	 */
> > -	cpu_pm_exit();
> > -
> >   	/*
> >   	 * Call idle CPU cluster PM exit notifier chain
> >   	 * to restore GIC and wakeupgen context.
> >   	 */
> >   	if (dev->cpu == 0 && mpuss_can_lose_context)
> >   		cpu_cluster_pm_exit();
> > +cpu_pm_out:
> > +	/*
> > +	 * Call idle CPU PM exit notifier chain to restore
> > +	 * VFP and per CPU IRQ context.
> > +	 */
> > +	cpu_pm_exit();
> 
> It looks ok, in general, but you've changed order of calls here,
> so may be commit message need to be updated

Hmm yeah good point, that's how it's usually done. I'll check
and update the description like you suggested.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux