Hi! > On Wed, Jan 10, 2018 at 09:53:15AM +0100, Pavel Machek wrote: > > From: Filip Matijević <filip.matijevic.pz@xxxxxxxxx> > > > > Add bindings for Nokia N9 audio components. > > > > Signed-off-by: Filip Matijević <filip.matijevic.pz@xxxxxxxxx> > > Signed-off-by: Pavel Machek <pavel@xxxxxx> > > > > diff --git a/Documentation/devicetree/bindings/media/ti-wl1273.txt b/Documentation/devicetree/bindings/media/ti-wl1273.txt > > new file mode 100644 > > index 0000000..21db389 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/media/ti-wl1273.txt > > @@ -0,0 +1,36 @@ > > +Texas Instruments - wl1273 radio/bluetooth module > > + > > +Required properties: > > + > > +- compatible - "ti,wl1273-core" > > +- reg - I2C slave address > > +- interrupts - The interrupt output from the device. > > +- interrupt-parent - The parent interrupt controller. > > +- power-gpio - gpio pin to power the device. > > + > > +- wl1273radio child - compatible = "ti,wl1273-fm-radio"; > > I'd document this under a separate section, as the compatible property for > the other child node. > > You use "property - description" here but "property: description" in the > file below. It'd be nice to be consistent, albeit it's separate > files. Heh. If we want to do consistency, it should be consistent in whole documentation. I looked at cec-gpio.txt and it uses both styles. Sampled few more files, and seems ":" is more common here. > > + > > +Optional properties: > > + > > +- wl1273codec child - compatible = "ti,wl1273codec"; > > "ti,wl1273-codec" Ok. > > diff --git a/Documentation/devicetree/bindings/sound/nokia,n9.txt b/Documentation/devicetree/bindings/sound/nokia,n9.txt > > new file mode 100644 > > index 0000000..230b1eb > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/nokia,n9.txt > > @@ -0,0 +1,32 @@ > > +* Nokia N9/N950 audio setup > > + > > A small description saying what this really is would be nice. I'm actually not sure what to say here. Suggestions? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachment:
signature.asc
Description: Digital signature
