On Fri, Dec 01, 2017 at 08:49:38AM +0100, H. Nikolaus Schaller wrote: > This allows to set CONFIG_W2SG0004_DEBUG which will > make the driver report more activities and it will turn on the > GPS module during boot while the driver assumes that it > is off. This can be used to debug the correct functioning of > the hardware. Therefore we add it as an option to the driver > because we think it is of general use (and a little tricky to > add by system testers). > > Normally it should be off. > > Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx> > --- > drivers/misc/Kconfig | 8 ++++++++ > drivers/misc/w2sg0004.c | 37 +++++++++++++++++++++++++++++++++++++ > 2 files changed, 45 insertions(+) I'd say say this does not belong in the kernel at all. And even if the power-state test were to be allowed, most of the pr_debugs would need to go. You really should be using dev_dbg and friends, which can already be enabled selectively at run time using dynamic debugging. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
