On Fri, Dec 1, 2017 at 7:23 PM, Sebastian Reichel <sre@xxxxxxxxxx> wrote: > Hi, > > On Fri, Dec 01, 2017 at 06:48:44PM -0600, Adam Ford wrote: >> I am looking to add S-video to an older OMAP3530 and DM3730 and I was >> looking at the bindings and comparing them to the driver. >> >> Documentation/devicetree/bindings/display/connector/analog-tv-connector.txt >> shows the compatible string to be "composite-video-connector" or >> "svideo-connector" but when I review the driver >> drivers/video/fbdev/omap2/omapfb/displays/connector-analog-tv.c and >> drivers/gpu/drm/omapdrm/displays/connector-analog-tv.c they both show >> it to be "omapdss,svideo-connector" while a different driver >> (meson_drv.c) shows it to be "svideo-connector" which is consistent >> with the binding text file. >> >> omap3-beagle.dts, omap3-beagle-xm.dts, omap3-gta04.dtsi, and >> omap3-devkit8000-common.dtsi all show just "svideo-connector" but it >> seems odd that they would not match the string in the driver. >> >> Should the strings in the driver be changed, or does the "omapdss," >> portion get ignored? >> >> I haven't actually tested this yet, because I am having a difficult >> time finding an S-Video monitor, but I'd like to be confident before I >> test it. > > The "omapdss," prefix is added at runtime during early init by the > omapdrm core. This is done, since omapdss does not support generic > connector/panel drivers, but the binding should be generic. > > The correct implementation is: > > * Binding does not have "omapdss," prefix > * DTS does not have "omapdss," prefix > * Driver _has_ "omapdss," prefix > Thank you for the clarification. It's what I assumed, but I wanted to double check. adam > -- Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
