On 30/11/17 18:09, Tony Lindgren wrote: > * Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx> [171130 10:21]: >> On Wed, 15 Nov 2017 17:23:06 +0100 >> Ladislav Michl <ladis@xxxxxxxxxxxxxx> wrote: >> >>> this patch serie updates OMAP2+ OneNAND driver to the present times, making >>> it fully DT configurable, using libgpio and dmaengine apis - those are >>> optional, driver will work without them. >>> >>> Please note that unlike previous driver version, which basically ignored >>> DT specified timings, this one relies on it, so it is important to get >>> it right in your DT (dumping it from previous kernel version). >>> >>> In case synchronous timings is requested, it is okay to specify timings >>> for the slowest chip ever used for you board as it is evetually optimized >>> after chip probe. >>> >>> Original driver used DMA only if user specified INT gpio in platform >>> data, now DMA is used unconditionally and PIO mode is used as fallback. >>> >>> In case anyone wants to give it a try, few DT related changes are needed: >>> - onenand node needs 'ti,omap2-onenand' compatible (for mailine boards this is >>> done in patch 2) >>> - to use INT pin, int-gpios needs to be specified (for n900 and n8x0 this is >>> done in patch 16, however patch lacks pinmux configuration. >>> >>> Most notable changes from v3: >>> - added dmaengine patches by Peter Ujfalusi >>> - added dt bindings documentation >>> - added cleanup patches >>> - DMA enabled by default >>> >>> Most notable changes from v4: >>> - collected tags >>> - used INT pin name properly >>> - hopefully all comments taken into account >>> >>> Also note that driver will fail probe OneNAND chip after patch 13 and start >>> working again after patch 14. >> >> Well, breaking bisectability is never a good thing, this being said, I >> won't complain if TI maintainers are okay with that. > > There should not be any reason to break git bisect for booting at all, > what exactly is the issue here? > >>> Testing and benchmarking very welcome. >> >> Let me know when you think this series is ready to be merged. > > Well we need Aaro to test this on n8x0 as my n800 is currently not > booting at all. > >>> Depends on "memory: omap-gpmc: Make 'bank-width' property optional" >>> https://patchwork.kernel.org/patch/10043259/ >> >> Hm, I see this patch has been applied to the omap tree, so maybe it's >> simpler if everything goes through this tree. I don't plan to modify >> onenand related stuff in this release anyway. > > Maybe Roger can provide you with an immutable commit with just that > patch? Here you go The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) are available in the git repository at: https://github.com/rogerq/linux.git for-v4.16/gpmc-omap-immutable for you to fetch changes up to c18a7ac3398d0cef29749f9568666db8321aa4c9: memory: omap-gpmc: Make 'bank-width' property optional (2017-12-01 15:37:49 +0200) ---------------------------------------------------------------- Ladislav Michl (1): memory: omap-gpmc: Make 'bank-width' property optional drivers/memory/omap-gpmc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- cheers, -roger Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
