* Keerthy <j-keerthy@xxxxxx> [171109 08:09]: > > > On Thursday 09 November 2017 09:55 AM, Keerthy wrote: > > > > > > On Wednesday 08 November 2017 10:12 PM, Tony Lindgren wrote: > >> * Keerthy <j-keerthy@xxxxxx> [171108 12:31]: > >>> The header file is currently under plat-omap directory > >>> under arch/omap. Move this out to an accessible place. > >>> > >>> No Code changes done to the header file. > >> > >> Some of the dmtimer functions are in this header to optimize the > >> size of the system timer code. Can you please check if some of them > >> can be left out of dmtimer.h and be made private to mach-omap1/timer.c > >> and mach-omap2/timer.c? > > > > Okay. I will try to clean that as well. > > Tony, > > Only function that i could push out of dmtimer.h was > __omap_dm_timer_override_errata > > which is being currently called by mach-omap2/timer.c alone. Hmm OK thanks for checking. > Rest all are used both my dmtimer.c as well as mach-omap2/timer.c. > Here is the list: > > __omap_dm_timer_read > __omap_dm_timer_write > __omap_dm_timer_init_regs > __omap_dm_timer_enable_posted > __omap_dm_timer_stop > __omap_dm_timer_load_start > __omap_dm_timer_int_enable > __omap_dm_timer_read_counter > __omap_dm_timer_write_status > > Any preferences on moving them to dmtimer.c or leaving them in header file? How about we make the system timer functions and these header functions private to the dmtimer.c. Then we can have the SoC specific system timer functions be selected based on comaptible value like drivers typically do :) I think only the SoC specific init code should be left in arch/arm/mach-omap[12]/timer.c. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
