Re: [PATCH] ARM: dts: logicpd-som-lv: Fix gpmc addresses for NAND and enet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 30/10/17 16:12, Adam Ford wrote:
> On Mon, Oct 30, 2017 at 8:46 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
>> * Roger Quadros <rogerq@xxxxxx> [171030 08:06]:
>>> On 28/10/17 16:42, Adam Ford wrote:
>>>> --- a/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts
>>>> +++ b/arch/arm/boot/dts/logicpd-som-lv-37xx-devkit.dts
>>>> @@ -72,7 +72,8 @@
>>>>  };
>>>>
>>>>  &gpmc {
>>>> -   ranges = <1 0 0x08000000 0x1000000>;    /* CS1: 16MB for LAN9221 */
>>>> +   ranges = <0 0 0x30000000 0x1000000      /* CS0: 16MB for NAND */
>>>
>>> NAND does not need 16MB space. It just needs 4 bytes of I/O space.
>>
>> Don't we have a minimum 16MB range needed for gpmc, then the
>> device register can be just 4 bytes?
>>

Sorry for the noise. Tony is right.

> 
> Looking at the Torepdo (from which I based this patch), it lists:
> 
> ranges = <0 0 0x30000000 0x1000000>; /* CS0: 16MB for NAND */

The ranges property defines the chip select range which
can be a minimum of 16MB.

> 
> nand@0,0 {
> compatible = "ti,omap2-nand";
> reg = <0 0 4>; /* CS0, offset 0, IO size 4 */

Yes, here is where we need 4 bytes.

> 
> Roger did that patch as part of 44e4716499b8 ("ARM: dts: omap3: Fix
> NAND device nodes")
> 
> and I am just trying to apply it to this other board.
> 
> Let me know what it should be, and I can fix (and/or test) it.  It's a
> 512MB NAND part for whatever that's worth.
> 
> adam
> 
>> Regards,
>>
>> Tony

-- 
cheers,
-roger

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux