Re: [PATCH 01/27] clk: ti: clkctrl: fix error messages to print out node name properly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Oct 30, 2017 at 03:04:19PM +0200, Tero Kristo wrote:
> Current node name does not convey any information, as it is always "clk".
> Instead, print out the full node path, which will tell us better where
> something went wrong.
> 
> Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>

-- Sebastian

>  drivers/clk/ti/clkctrl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/ti/clkctrl.c b/drivers/clk/ti/clkctrl.c
> index 53e71d0..2db7d40 100644
> --- a/drivers/clk/ti/clkctrl.c
> +++ b/drivers/clk/ti/clkctrl.c
> @@ -351,8 +351,8 @@ static struct clk_hw *_ti_omap4_clkctrl_xlate(struct of_phandle_args *clkspec,
>  	if (ti_clk_parse_divider_data((int *)div_data->dividers,
>  				      div_data->max_div, 0, 0,
>  				      &div->width, &div->table)) {
> -		pr_err("%s: Data parsing for %s:%04x:%d failed\n", __func__,
> -		       node->name, offset, data->bit);
> +		pr_err("%s: Data parsing for %pOF:%04x:%d failed\n", __func__,
> +		       node, offset, data->bit);
>  		kfree(div);
>  		return;
>  	}
> @@ -428,7 +428,7 @@ static void __init _ti_omap4_clkctrl_setup(struct device_node *node)
>  	}
>  
>  	if (!data->addr) {
> -		pr_err("%s not found from clkctrl data.\n", node->name);
> +		pr_err("%pOF not found from clkctrl data.\n", node);
>  		return;
>  	}
>  
> -- 
> 1.9.1
> 
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux