Re: [PATCH 11/11] ARM: OMAP2+: gpmc-onenand: Remove

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Ladislav Michl <ladis@xxxxxxxxxxxxxx> [171017 01:51]:
> On Tue, Oct 17, 2017 at 11:11:41AM +0300, Roger Quadros wrote:
> > 
> > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
> > 
> > On 16/10/17 02:23, Ladislav Michl wrote:
> > > Remove now dead code.
> > > 
> > > Signed-off-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx>
> > > ---
> > >  arch/arm/mach-omap2/Makefile                    |   3 -
> > >  arch/arm/mach-omap2/gpmc-onenand.c              | 349 ------------------------
> > >  include/linux/platform_data/mtd-onenand-omap2.h |  34 ---
> > >  3 files changed, 386 deletions(-)
> > 
> > Since we're aiming to get rid of mach-omap2/gpmc-onenand.c I don't think
> > we should need patches 1 to 6 that try to clean it up.
> 
> As stated in cover letter, sole purpose of patches 1-5 is to get functions
> which are later moved into drivers/memory/omap-gpmc.c. I hope someone will
> volunteer to review them and verify reasoning. Once agreed modifications are
> correct, I'll drop them from next version. On the other side, it is always
> nice when you know where code comes from frm the git history.
> 
> > Also, since nand and mach-omap2 patches would go in separate trees during the merge window,
> > I wouldn't yet git rid of mach-omap2/gpmc-onenand.c and platform data yet.
> > We can do that once the onenand DT adaptation is complete.
> 
> Sure. Idea was to merge patches 6,7 and 8 via linux-omap and then patch 9
> via linux-mtd. I do not think it is possible merge everything in paralel
> during one merge window. Clean uu can be then done anytime later.

Best to merge it all via MTD, I can ack the mach-omap2 patches as needed.
I also need to test at some point that onenand still works with n8x0 and
n900.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux