On Tue, Oct 17, 2017 at 10:55:15AM +0300, Roger Quadros wrote: > Hi, > > > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > > On 16/10/17 02:16, Ladislav Michl wrote: > > Hi! > > > > this is an attempt to make OMAP2+ OneNAND driver DT aware. > > > > Patches 1-5 could be probably omitted from later versions as their sole > > purpose is to show code modifications which lead into patch 8. > > Please take special attention to this patch as it is not yet finished. > > We need latency and sync r/w mode to be returned from > > gpmc_omap_onenand_set_sync_timings function, but I'm not happy with > > any interface so far (return flags togerher with latency, return struct?). > > Perhaps someone could come with different approach. > > > > Also note that timings information from DT is not used at all, but needs > > Why is that? Shouldn't ASYNC timings/settings be programmed by the omap-gpmc driver? It is programmed by the omap-gpmc driver, but timings information comes from gpmc_omap_onenand_calc_async_timings function not from DT. > > to be present, otherwise generic node probing code will bail out with > > no timings. That's also worth fixing. > > > > > Ladislav Michl (11): > > ARM: OMAP2+: gpmc-onenand: of_node is always set > > ARM: OMAP2+: gpmc-onenand: Drop global gpmc_settings > > ARM: OMAP2+: gpmc-onenand: Drop global latency variable > > ARM: OMAP2+: gpmc-onenand: Simplify flags handling > > ARM: OMAP2+: gpmc-onenand: Drop global flags variable > > ARM: OMAP2+: gpmc-onenand: Add helper init function > > memory: omap-gpmc: Merge gpmc_probe_onenand_child into > > gpmc_probe_child > > memory: omap-gpmc: Add OneNAND timings calc functions > > mtd: onenand: omap2: Configure driver from DT > > memory: omap-gpmc: Do not use omap_onenand_platform_data > > ARM: OMAP2+: gpmc-onenand: Remove > > > > arch/arm/mach-omap2/Makefile | 3 - > > arch/arm/mach-omap2/gpmc-onenand.c | 409 ------------------------ > > drivers/memory/omap-gpmc.c | 239 +++++++++++--- > > drivers/mtd/onenand/omap2.c | 145 +++++++-- > > include/linux/omap-gpmc.h | 7 + > > include/linux/platform_data/mtd-onenand-omap2.h | 34 -- > > 6 files changed, 313 insertions(+), 524 deletions(-) > > delete mode 100644 arch/arm/mach-omap2/gpmc-onenand.c > > delete mode 100644 include/linux/platform_data/mtd-onenand-omap2.h > > > > -- > cheers, > -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
