> > > is a static function. The only user of omap4_globals is > > > __omap4_set_globals. > > > It looks to me like the only purpose of omap4_globals is to pass a > > > structure to __omap4_set_globals. Why not use a function > > > argument instead? > > Indeed. Actually I just more or less followed what is done > for OMAP2/OMAP3 here. I will clean this for OMAP4. > > > > Tony, > > We may want to clean up this for OMAP2/OMAP3 as well. Can > we add this to the clean up patches planned if any. I can > create the patch. > > Sure, please post that patch for review. OK Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
