On Mon, May 18, 2009 at 09:31:26AM +0300, Hiroshi DOYU wrote: > Right. In this change for better performance, I have to expose "struct > mem_type" and "get_mem_type()" a bit more as below. Is this change > acceptable, or do you have a better idea? You don't need to expose struct mem_type at all. You only need to tell the compiler that it exists and is valid by: struct mem_type; Then you can use it in function prototypes without complaint. I'd also prefer to hide ioremap_page() and get_mem_type() outside of the normal Linux headers - maybe in asm/mach/map.h. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html