On Sun, May 17, 2009 at 06:30:27PM +0530, Shilimkar, Santosh wrote: > Russell, > > > > diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c > > > index 916fcd3..6db7791 100644 > > > --- a/arch/arm/mach-omap2/io.c > > > +++ b/arch/arm/mach-omap2/io.c > > > @@ -200,7 +247,9 @@ void __init omap2_init_common_hw(struct > > omap_sdrc_params *sp) > > > omap2_mux_init(); > > > pwrdm_init(powerdomains_omap); > > > clkdm_init(clockdomains_omap, clkdm_pwrdm_autodeps); > > > +#ifndef CONFIG_ARCH_OMAP4 /* FIXME: Remove this once the > > clkdev is ready */ > > > omap2_clk_init(); > > > +#endif > > > omap2_sdrc_init(sp); > > > gpmc_init(); > > > } > > > > I'm not sure why: > > > > 1. you're using a (possible) run time check in sdrc.c, > > clockdomain.c and > > powerdomain.c, but a compile time check in io.c > This one I explained in the last email. And till we have the clean up > done on clock.h I can't remove the compile time switch even though it > looks ugly. There's no point in using run-time checks here though. This is a temporary hack until OMAP4 gets the proper clock/clockdomain/powerdomain/ sdrc support. Until that happens, there's no point in mixing this stuff up and making more review work. So just accept that OMAP4 won't live with anything but itself for the time being and do as: omap2_mux_init(); +#ifndef CONFIG_ARCH_OMAP4 /* FIXME: Remove this once the clkdev is ready */ pwrdm_init(powerdomains_omap); clkdm_init(clockdomains_omap, clkdm_pwrdm_autodeps); omap2_clk_init(); omap2_sdrc_init(sp); +#endif gpmc_init(); Nice and simple, fewer files touched and obvious what's going on. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
