> -----Original Message----- > From: Russell King - ARM Linux [mailto:linux@xxxxxxxxxxxxxxxx] > Sent: Saturday, May 16, 2009 3:38 PM > To: Shilimkar, Santosh > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxxxxx; > linux-omap@xxxxxxxxxxxxxxx > Subject: Re: [RESUBMIT][PATCH 5/7] OMAP4: Update common omap > machine specific sources. > > I think this is going to take several separate reviews to group stuff > together. Do you mean this patch or CLKDEV related work ? > > diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c > > index 916fcd3..6db7791 100644 > > --- a/arch/arm/mach-omap2/io.c > > +++ b/arch/arm/mach-omap2/io.c > > @@ -200,7 +247,9 @@ void __init omap2_init_common_hw(struct > omap_sdrc_params *sp) > > omap2_mux_init(); > > pwrdm_init(powerdomains_omap); > > clkdm_init(clockdomains_omap, clkdm_pwrdm_autodeps); > > +#ifndef CONFIG_ARCH_OMAP4 /* FIXME: Remove this once the > clkdev is ready */ > > omap2_clk_init(); > > +#endif > > omap2_sdrc_init(sp); > > gpmc_init(); > > } > > I'm not sure why: > > 1. you're using a (possible) run time check in sdrc.c, > clockdomain.c and > powerdomain.c, but a compile time check in io.c > 2. you don't leave sdrc.c, clockdomain.c and powerdomain.c > alone and just > disable the three initialisation calls inside > omap2_init_common_hw(). Because to have omap2_clk_init() under run time check needs clock.h Rest of the problem as mentioned below, you know already. *********************************************************************************************** > @@ -30,7 +32,9 @@ > #include <mach/sdrc.h> > #include <mach/gpmc.h> > > +#ifndef CONFIG_ARCH_OMAP4 /* FIXME: Remove this once clkdev is ready */ > #include "clock.h" > +#endif Hmm. Tony: we really need to eliminate data inside header files. It's not nice to have data structures created by merely including some header file that also contains function prototypes. *********************************************************************************************** Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
