Re: [PATCH 6/8] ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> [090516 02:06]:
> On Thu, May 14, 2009 at 01:28:06PM -0700, Tony Lindgren wrote:
> > commit 27db33cfadd3c47c9499def6e71aaf5d2fd51e60
> > Author: Tony Lindgren <tony@xxxxxxxxxxx>
> > Date:   Tue May 12 11:20:03 2009 -0700
> > 
> >     ARM: OMAP2/3: Change omapfb to use clkdev for dispc and rfbi, v2
> >     
> >     This makes the framebuffer work on omap3.
> >     
> >     Also fix the clk_get usage for checkpatch.pl
> >     "ERROR: do not use assignment in if condition".
> >     
> >     Cc: Imre Deak <imre.deak@xxxxxxxxx>
> >     Cc: linux-fbdev-devel@xxxxxxxxxxxxxxxxxxxxx
> >     Acked-by: Krzysztof Helt <krzysztof.h1@xxxxx>
> >     Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> 
> This isn't a bug fix - the current code works, although checkpatch will
> complain about the assignment in the if condition.
> 
> The rest of the patch is just a conversion from the old way of doing
> things to the new way, and I don't think is -rc material.

The code does not work for omap3 without this patch because of the
different clock names. It only works for 24xx. And because of the
different source clocks, it's pointless trying to fix it in any
other way for -rc series.

Dropping anyways from the omap-fixes series, we can wait a bit
longer.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux