On 25/05/17 23:07, Uwe Kleine-König wrote: > Instead of failing silently log a hint for the dt author about the > reason of the failure. > > Signed-off-by: Uwe Kleine-König <uwe@xxxxxxxxxxxxxxxxx> Acked-by: Roger Quadros <rogerq@xxxxxx> > --- > drivers/memory/omap-gpmc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c > index 44b79db20021..2a46e6fd7d47 100644 > --- a/drivers/memory/omap-gpmc.c > +++ b/drivers/memory/omap-gpmc.c > @@ -2083,8 +2083,11 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, > } else { > ret = of_property_read_u32(child, "bank-width", > &gpmc_s.device_width); > - if (ret < 0) > + if (ret < 0) { > + dev_err(&pdev->dev, "%s has no 'bank-width' property\n", > + child->full_name); > goto err; > + } > } > > /* Reserve wait pin if it is required and valid */ > -- cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html