* Jagadeesh Bhaskar Pakaravoor <jagadeeshbp@xxxxxxxxx> [090514 03:34]: > > IMO, The regs do not need to move to a separate header unless they will > > be used outside of i2c-omap.c. > > > Would it not be cleaner to move them to a separate header file, > especially considering the fact that we have some 19 registers for > OMAP3 I2C and when we redefine them for OMAP4, there would be 38 > (infact 40, including the two new registers) lines of just register > definitions at the top of the file? I agree with Kevin, unless the defines are used in other files there should not be need for having a separate header file. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
