Hi,
On Tue, May 09, 2017 at 03:10:40PM +0300, Tomi Valkeinen wrote:
> On 08/05/17 14:32, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch series is a second, extended version of the code previously posted
> > as "[PATCH/RFC 0/7] Remove the omapdrm device from platform code".
>
> As this is a long series, I'd like to pick a bunch of patches from this
> series already:
>
> 1-5, 7, 19, 21.
I can't reply directly, since I was not subscribed to dri-devel when
this was sent, but I also noticed, the incorrect pattern in patch 1:
foo = devm_ioremap_resource(...)
if (!foo)
return -ENOMEM;
The same pattern is in patch 2, so you may want a PATCHv2 of that
one first. Also I have a few more notes:
patch 10:
I think dsi pin muxing should be done by providing pinmux
info via DT.
patch 11:
There is a typo in the comment "can be told apart" => "can't be told
apart".
patch 21:
As far as I can see dss.h contains an empty #if
defined(CONFIG_OMAP2_DSS_DEBUGFS) after the patch.
> I didn't test yet, but I think those should not cause conflicts with the
> rest of the series.
>
> I can then push the branch, which contains also the fences and cache
> patches, so you can base the rest on that.
>
> Is this ok?
-- Sebastian
Attachment:
signature.asc
Description: PGP signature
