Hi Tony,
On 06/05/17 01:37, Tony Lindgren wrote:
> The width needs to be configured in bytes with 1 meaning 8-bit
> access and 2 meaning 16-bit access.
As per the TRM, for GPMC_CONFIG1.DEVICESIZE
0 means 8-bit
1 means 16-bit
>
> Cc: Peter Ujfalusi <peter.ujfalusi@xxxxxx>
> Cc: Roger Quadros <rogerq@xxxxxx>
> Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> ---
> drivers/memory/omap-gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -513,7 +513,7 @@ static void gpmc_cs_show_timings(int cs, const char *desc)
> pr_info("gpmc cs%i access configuration:\n", cs);
> GPMC_GET_RAW_BOOL(GPMC_CS_CONFIG1, 4, 4, "time-para-granularity");
> GPMC_GET_RAW(GPMC_CS_CONFIG1, 8, 9, "mux-add-data");
> - GPMC_GET_RAW_MAX(GPMC_CS_CONFIG1, 12, 13,
> + GPMC_GET_RAW_SHIFT_MAX(GPMC_CS_CONFIG1, 12, 13, 1,
> GPMC_CONFIG1_DEVICESIZE_MAX, "device-width");
setting shift 1 means the value will be multiplied by 2
so this will read 0 for 8-bit and 2 for 16-bit.
Is this what we want?
I'd still prefer the old way of showing RAW values than interpreted ones.
> GPMC_GET_RAW(GPMC_CS_CONFIG1, 16, 17, "wait-pin");
> GPMC_GET_RAW_BOOL(GPMC_CS_CONFIG1, 21, 21, "wait-on-write");
>
--
cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
