On Wed, 2009-05-13 at 18:54 +0200, ext Kevin Hilman wrote: > Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> writes: > > > On Wed, 2009-05-13 at 17:10 +0200, ext Kevin Hilman wrote: > >> Phil Carmody <ext-phil.2.carmody@xxxxxxxxx> writes: > >> > >> > A couple of simple patches to improve error handling in smartreflex. > >> > The first has a practical benefit of avoiding a string-based search > >> > in situtations where the result wouldn't be needed. The second is > >> > simple paranoia. > >> > >> Thanks, pushing this series today. > >> > >> Note that I pushed this on top of Rajendra's patch: > >> "OMAP3: SR: Fix SR driver to check for omap-pm return values" > >> and had to resolve a couple of conflicts. > >> > >> Could you please sanity check it? > > > > Sanity check successful. Many thanks, Kevin. > > Hmm, you're too fast for me. It's the time zone difference! > Not sure how you tested as I hadn't pushed your changes yet ;) > > I just pushed them to my pm branch, but they are not yet sync'd to > tony's tree. Can you try now. Freshly pulled, indeed I now see the extent of the rework. I don't know whether -ENODEV or -EINVAL is better, the former just came to mind first when I was in the file. Either way, it looks fine. Thanks again. Phil -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html