On 15/04/17 20:05, Tony Lindgren wrote: > The idle mode needs to be only disabled for UTMIAUTOIDLE while > ULPIAUTOIDLE can be enabled. > > This matches the TLL_CHANNEL_CONF_i register configuration for ehci-tll > in the Motorola Linux kernel tree for Wrigley 3G LTE modem on droid 4 > and the modem still stays responsive. > > Cc: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> > Cc: Keshava Munegowda <keshava_mgowda@xxxxxx> > Cc: Marcel Partap <mpartap@xxxxxxx> > Cc: Michael Scott <michael.scott@xxxxxxxxxx> > Cc: Roger Quadros <rogerq@xxxxxx> > Cc: Sebastian Reichel <sre@xxxxxxxxxx> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx> Acked-by: Roger Quadros <rogerq@xxxxxx> > --- > drivers/mfd/omap-usb-tll.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c > --- a/drivers/mfd/omap-usb-tll.c > +++ b/drivers/mfd/omap-usb-tll.c > @@ -373,12 +373,13 @@ int omap_tll_init(struct usbhs_omap_platform_data *pdata) > } else if (pdata->port_mode[i] == > OMAP_EHCI_PORT_MODE_TLL) { > /* > - * Disable AutoIdle, BitStuffing > - * and use SDR Mode > + * Disable UTMI AutoIdle, BitStuffing > + * and use SDR Mode. Enable ULPI AutoIdle. > */ > reg &= ~(OMAP_TLL_CHANNEL_CONF_UTMIAUTOIDLE > | OMAP_TLL_CHANNEL_CONF_ULPIDDRMODE); > reg |= OMAP_TLL_CHANNEL_CONF_ULPINOBITSTUFF; > + reg |= OMAP_TLL_CHANNEL_CONF_ULPI_ULPIAUTOIDLE; > } else if (pdata->port_mode[i] == > OMAP_EHCI_PORT_MODE_HSIC) { > /* > cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html