* Felipe Balbi <felipe.balbi@xxxxxxxxx> [090513 17:33]: > On Thu, May 14, 2009 at 01:46:51AM +0200, ext Andrew de Quincey wrote: > > Hi, I've just discovered that the patch at: > > > > http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=commitdiff;h=3eae3ea7c443fc4330574dffea65b6f2f53a2574 > > > > Breaks the nokia770's framebuffer as it removes the platform data for > > the HWA742 LCD controller. > > > > As the patch says "Patches against the mainline tree are welcome to > > add back the missing functionality if needed!", I'm happy to do this. > > > > However, since I'm fairly new to the linux-omap project, is simply > > extracting the removed nokia770 code and generating a patch against > > the mainline kernel sufficient? or is there a newer style of some sort > > that should be adopted for this? > > You can start by generating the new patch against mainline and running > scripts/checkpatch.pl, then you should probably find out if there are > any API changes and stuff like that. Then send the patch to lkml ccing > linux-omap and let's see what comments do you get from those guys :-) Please change the code to pass the struct clock to drivers/video/omap/hwa742.c in hwa742_platform_data. The hw742.c can just do standard clk_enable/disable there. Otherwise we won't be able to get this missing part to the mainline kernel. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
