* Tero Kristo <t-kristo@xxxxxx> [170410 11:36]: > On 10/04/17 19:18, Tony Lindgren wrote: > > * Tero Kristo <t-kristo@xxxxxx> [170410 00:34]: > > > On 07/04/17 19:47, Tony Lindgren wrote: > > > > OK hdmi works now on panda for both omapfb and omapdrm. Any ideas why > > > > that change is now needed though? > > > > > > Yes, it is pretty clear actually. Previously, the hwmod main clock was > > > controlling the hdmi clock, but this is now rerouted to the clkctrl module > > > clock, which is shared between all DSS submodules. This leaves the hdmi > > > clock disabled, causing the failure. > > > > > > The fix just puts the hdmi clock into the optional clocks list, and forces > > > all the optional clocks on when pm_runtime is enabled for the module. > > > > OK so no need to fix it in the current kernels then. > > Yeah, just need to figure out a clean order of applying these patches. The > hwmod data change for DSS modules can most likely be applied before the dts > change for clkctrl is going in, as it is just causing double clk_enable / > disable for the main clocks in that case. Yeah no idea about the hwmod change needed for DSS.. Maybe patch it in only in the no "ti,hwmods" path? For the rest, how about the following for getting things patched with a minimal patching needed to revert in case of regressions: 1. Let's add the clkctrl driver and it's dts clocks. Let's tag the new clkctrl clocks with status = "disabled" and not add the consumers into any existing devices 2. Let's modify the dts files to add the hwmod related items for the wrapper IP module but let's keep things probing the old way using compatible = "simple-bus" for now 3. Let's add the wrapper IP driver and make sure it does nothing except probe the children just like "simple-bus" currently does if the child module has the "ti,hwmods" property set 4. Then we can finally start flipping things over one module at a time just by removing "ti,hwmods" for the child device and status = "disabled" for the related module clock Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
