On Sat, Mar 4, 2017 at 5:23 PM, Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> wrote: > The following series uses the recently introduced set of > devm_irq_alloc_desc*() helpers in the GPIO drivers. > > While we're at it: if the modified drivers called request_irq(), it > was changed to devm_request_irq() too. > > Some drivers correctly clean up resources (e.g. gpio-mockup, > gpio-pch) - for them this change leads to an actual code shrink. > > Other drivers are meant to be built-in and the devices they control > are never removed (e.g. gpio-pxa, gpio-davinci), so they deliberately > omit the cleanup. Still: in case something changes it's better to free > the resources - especially since these drivers already use other > devm_* routines like devm_kzalloc() etc. > > The last group of drivers are the ones which can be compiled as > modules, but leak resources unintentionally (e.g. gpio-twl4030, > gpio-omap). This change fixes the interrupt descriptor leaks, but some > drivers will require additional work since they still don't release > other resources. > > The following drivers were tested: gpio-mockup, gpio-omap > and gpio-davinci. The rest was compile-tested only. > > Bartosz Golaszewski (12): > gpio: mockup: use devm_irq_alloc_descs() > gpio: twl4030: use devm_irq_alloc_descs() > gpio: omap: use devm_irq_alloc_descs() > gpio: pch: use resource management for irqs > gpio: ml-ioh: use resource management for irqs > gpio: xlp: use resource management for irqs > gpio: pxa: use devm_irq_alloc_descs() > gpio: davinci: use devm_irq_alloc_descs() > gpio: sodaville: use resource management for irqs > gpio: mxc: use devm_irq_alloc_descs() > gpio: mxs: use devm_irq_alloc_descs() > gpio: sta2x11: use resource management for irqs Excellent series, applied all and pushing to the build servers for testing. Interested in the job to go over to drivers/pinctrl and check if we have some dangling descs there if this works out? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
