Re: [PATCH 2/2] DSPBRIDGE: add checking 128 byte alignment for dsp cache line size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 11, 2009 at 9:26 PM, Kanigeri, Hari <h-kanigeri2@xxxxxx> wrote:
> To summarize the discussion.
>
> We need to have the check for 128 bytes alignment (upper and lower). The 2 places that this can be done are in flush function or in Map function.
>
>        - I prefer the check is done in Map function as Felipe mentioned this function is bound to be called by MM components as opposed to Flush function. Also, another reason is the flush function in Bridge driver is going to be removed eventually.
>
> The open issue is the impact on the OMX components. Once if we finalize that there is no impact on the existing OMX components or we have a plan to take this into account we can enforce this check.

First of all the check is not required on input buffers, enforcing it
will make memory copy unavoidable on certain situations. That is not
good.

Also, it will break OMX components. The fix is trivial (use
posix_memalign for example) but code will need to be changed.

The easiest solution IMHO is to add a new ioctl which has other advantages.

-- 
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux