Re: [PATCH] ARM: dts: logicpd-torpedo-37xx-devkit: Remove unused features

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Adam Ford <aford173@xxxxxxxxx> [170216 14:00]:
> On Feb 16, 2017 3:46 PM, "Tony Lindgren" <tony@xxxxxxxxxxx> wrote:
> 
> * aford173@xxxxxxxxx <aford173@xxxxxxxxx> [170214 12:18]:
> > From: Adam Ford <aford173@xxxxxxxxx>
> >
> > By default, the TWL4030 charger, TWL4030-Keypad and SSI are enabled.
> > Logic PD recomends not using this charger for thermal reasons, and
> > the devkit does not suppor either the keypad or SSI. Because these
> > are enabled by default, but incomplete in the device tree, this
> > throws a few warnings/errors.  This patch will eliminate those
> > messages by disabling the unused features.
> >
> > Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> >
> > diff --git a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts
> b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts
> > index 08cce17..ee5f07f 100644
> > --- a/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts
> > +++ b/arch/arm/boot/dts/logicpd-torpedo-37xx-devkit.dts
> > @@ -402,3 +402,11 @@
> >       mode = <3>;
> >       power = <50>;
> >  };
> > +
> > +&ssi {
> > +     status = "disabled";
> > +};
> 
> You may want to measure the power consumption with this change
> as now ssi driver is never probed or idled so it's up to the
> bootloader to idle it properly.
> 
> 
> I didn't know that. I will run some tests. Can we hold off on applying this
> until I can check it?

Sure yeah I'll wait.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux