Hi, On Tuesday, February 07, 2017 05:41:37 PM Arvind Yadav wrote: > Hi, > > In dss_init_ports, There is no need to add dss_uninit_ports before > returning. > Because it's already take care in dss_bind. dss_bind is handling > dss_uninit_ports in error path. It doesn't handle cleanup of partially initialized ports, please look at the code: ... r = dss_init_ports(pdev); if (r) goto err_init_ports; ... err_runtime_get: pm_runtime_disable(&pdev->dev); dss_uninit_ports(pdev); err_init_ports: if (dss.video1_pll) dss_video_pll_uninit(dss.video1_pll); ... dss_uninit_ports() is not called on partially initialized ports (when dss_init_ports() returns an error we go straight into err_init_ports label and skip dss_uninit_ports()) > -Arvind > > > On Monday 06 February 2017 08:58 PM, Bartlomiej Zolnierkiewicz wrote: > > dpi_uninit_port() & sdi_uninit_port() skip not fully > > initialized port Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
