Re: [PATCH] mfd: twl4030-power: Fix pmic for boards that need vmmc1 on reboot

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 06 Feb 2017, Adam Ford wrote:

> On Sun, Jan 29, 2017 at 5:18 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:
> > * Adam Ford <aford173@xxxxxxxxx> [170129 04:41]:
> >> At least two different omap3630/3730 boards booting from MMC1
> >> fail to reboot if the "ti,twl4030-power-idle-osc-off" or
> >> "ti,twl4030-power-idle" compatible flags are set.  This patch will
> >> keep the vmmc1 powered up during reboot allowing the bootloader
> >> to load.
> >
> > Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>
> >
> 
> Gentle nudge.

No point in doing that.  You're not going to speed up the
process.  In fact, you've slowed it down, since I review patches in
reverse chronological order and you just bumped the thread to the top
of my inbox.  It's on the "to review" list and will get seen in due
course.

> I am not sure who has to apply this to the master, but once it's
> applied, I was going to request it be backported to 4.4+ because of
> the rebooting issues it corrects for our boards.
> 
> Thank you,
> 
> adam
> 
> >> Signed-off-by: Adam Ford <aford173@xxxxxxxxx>
> >>
> >> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> >> index 1beb722..e1e69a4 100644
> >> --- a/drivers/mfd/twl4030-power.c
> >> +++ b/drivers/mfd/twl4030-power.c
> >> @@ -701,6 +701,7 @@ static struct twl4030_ins omap3_wrst_seq[] = {
> >>       TWL_RESOURCE_RESET(RES_MAIN_REF),
> >>       TWL_RESOURCE_GROUP_RESET(RES_GRP_ALL, RES_TYPE_R0, RES_TYPE2_R2),
> >>       TWL_RESOURCE_RESET(RES_VUSB_3V1),
> >> +     TWL_RESOURCE_RESET(RES_VMMC1),
> >>       TWL_RESOURCE_GROUP_RESET(RES_GRP_ALL, RES_TYPE_R0, RES_TYPE2_R1),
> >>       TWL_RESOURCE_GROUP_RESET(RES_GRP_RC, RES_TYPE_ALL, RES_TYPE2_R0),
> >>       TWL_RESOURCE_ON(RES_RESET),
> >>

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Arm (vger)]     [ARM Kernel]     [ARM MSM]     [Linux Tegra]     [Linux WPAN Networking]     [Linux Wireless Networking]     [Maemo Users]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux