Hi, Just one comment below: > > Does the following make sense? > > > > +#define NR_IOMMU_RES 2 > > > > .... > > > > + err = platform_device_add_resources(pdev, > > + omap3_iommu_res + i * NR_IOMMU_RES, > NR_IOMMU_RES); > > Yeap, also: > > > + err = platform_device_add_resources(pdev, > omap3_iommu_res + i * 2, 2); IMHO, I don't think it's a good idea to add magical numbers to any code in the kernel. Why is it better to NOT use a define? Regards, Sergio -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
