Tony, On 01/26/2017 07:17 PM, Tony Lindgren wrote: > * Tony Lindgren <tony@xxxxxxxxxxx> [170126 07:08]: >> * Jarkko Nikula <jarkko.nikula@xxxxxxxxxx> [170126 00:47]: >>> On Thu, Jan 26, 2017 at 09:39:52AM +0200, Tomi Valkeinen wrote: >>>> On 25/01/17 19:50, Tony Lindgren wrote: >>>> >>>>>>> The LCD just stays blank with backlight off as soon as I load >>>>>>> panel_sony_acx565akm. >>>>>> >>>>>> Can you share the kernel logs for both boards? I don't have neither >>>>>> board, so I probably can't help too much here. >>>>> >>>>> Below are the relevant parts for both devices using v4.10-rc5. >>>> >>>> The logs look quite similar, and I don't see anything wrong there. >>>> >>>> Jarkko, you sent a patch for N900's panel a while ago, do you have the >>>> LCD working with omapdrm? >>>> >>> Yes I have but after probing the panel there has to do blank-unblank >>> cycle and I think setting the blacklight level too. I was going to check >>> it when that regression happened but didn't find time to do it yet. >> >> I've tried these too, no luck. Maybe I'm using the wrong sequence. >> >> Could it be that some of the GPIOs get toggled the wrong way around? > > Sorry Jarkko, you're right. This gets it working: > > # modprobe tsc2005 > # modprobe panel_sony_acx565akm > # modprobe omapdrm > # echo 255 > /sys/class/backlight/acx565akm/brightness > # echo 0 > /sys/class/graphics/fb0/blank > # echo 1 > /sys/class/graphics/fb0/blank > # echo 0 > /sys/class/graphics/fb0/blank > > That extra blank/unblank cycle seems a bit user unfriendly? most likely this will help: diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c index 5ab39e0060f2..d5a21a96ea82 100644 --- a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c +++ b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c @@ -839,7 +839,7 @@ static int acx565akm_probe(struct spi_device *spi) bldev->props.max_brightness = max_brightness; bldev->props.brightness = brightness; - acx565akm_bl_update_status(bldev); + backlight_update_status(bldev); ddata->vm = acx565akm_panel_vm; - Péter -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
